Add permission check to LoadIssuesFromBoard
#29643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
How to print executed SQL query in tests? It is so strange that only auto test not pass, manual test is ok. |
yp05327
force-pushed
the
fix-wrong-issues-in-projects
branch
from
33fe41f to
ef37c2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #22865
We already have
AllPublicoption, but why still need to addPublicRepoCondagain inissuePullAccessibleRepoCond?Then condition will look like:
If
AllPublicis true andopts.Useris not nil, because of the relationshipand, we will only find public repos of doer owned/ listed inaccesstable/ assigned,mentioned or created issues in it, so other public repos will be ignored.But it is not correct, as doer can also access these public repos.
#23630 maybe related.